Date
1 - 3 of 3
[PATCH] config_tools: expose own_pcpu to RTVM
Zhao, Yuanyuan
From: Yuanyuan Zhao <yuanyuan.zhao@...>
Expose own_pcpu widget to RTVM. Fix the value to true for RTVM
always own pcpus.
Signed-off-by: Yuanyuan Zhao <yuanyuan.zhao@...>
---
.../pages/Config/ConfigForm/CustomWidget/cpu_affinity.vue | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/misc/config_tools/configurator/packages/configurator/src/pages/Config/ConfigForm/CustomWidget/cpu_affinity.vue b/misc/config_tools/configurator/packages/configurator/src/pages/Config/ConfigForm/CustomWidget/cpu_affinity.vue
index 75939d193..4933ff3e6 100644
--- a/misc/config_tools/configurator/packages/configurator/src/pages/Config/ConfigForm/CustomWidget/cpu_affinity.vue
+++ b/misc/config_tools/configurator/packages/configurator/src/pages/Config/ConfigForm/CustomWidget/cpu_affinity.vue
@@ -3,7 +3,7 @@
<b>{{ uiOptions.title }}</b>
<div class="p-4">
<div v-if="defaultVal.pcpu && defaultVal.pcpu.length>0">
- <b-row v-if="is_std_vm">
+ <b-row>
<label>
<n-popover trigger="hover" placement="top-start" style="width: 500px">
<template #trigger>
@@ -146,7 +146,7 @@ export default {
return window.getCurrentFormSchemaData().BasicConfigType.definitions.CPUAffinityConfiguration.properties.pcpu_id
},
pcpu_owned() {
- return vueUtils.getPathVal(this.rootFormData, 'own_pcpu')
+ return this.is_std_vm ? vueUtils.getPathVal(this.rootFormData, 'own_pcpu') : 'y'
},
uiOptions() {
return formUtils.getUiOptions({
@@ -178,8 +178,7 @@ export default {
this.defaultVal.pcpu.splice(index + 1, 0, {pcpu_id: null, real_time_vcpu: "n"})
},
click_own_pcpu() {
- let newValue = this.pcpu_owned === 'y' ? 'n' : 'y';
- vueUtils.setPathVal(this.rootFormData, 'own_pcpu', newValue)
+ return this.is_std_vm ? (this.pcpu_owned === 'y' ? 'n' : 'y') : 'y'
},
removePCPU(index) {
if (this.defaultVal.pcpu.length === 1) {
--
2.25.1
Expose own_pcpu widget to RTVM. Fix the value to true for RTVM
always own pcpus.
Signed-off-by: Yuanyuan Zhao <yuanyuan.zhao@...>
---
.../pages/Config/ConfigForm/CustomWidget/cpu_affinity.vue | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/misc/config_tools/configurator/packages/configurator/src/pages/Config/ConfigForm/CustomWidget/cpu_affinity.vue b/misc/config_tools/configurator/packages/configurator/src/pages/Config/ConfigForm/CustomWidget/cpu_affinity.vue
index 75939d193..4933ff3e6 100644
--- a/misc/config_tools/configurator/packages/configurator/src/pages/Config/ConfigForm/CustomWidget/cpu_affinity.vue
+++ b/misc/config_tools/configurator/packages/configurator/src/pages/Config/ConfigForm/CustomWidget/cpu_affinity.vue
@@ -3,7 +3,7 @@
<b>{{ uiOptions.title }}</b>
<div class="p-4">
<div v-if="defaultVal.pcpu && defaultVal.pcpu.length>0">
- <b-row v-if="is_std_vm">
+ <b-row>
<label>
<n-popover trigger="hover" placement="top-start" style="width: 500px">
<template #trigger>
@@ -146,7 +146,7 @@ export default {
return window.getCurrentFormSchemaData().BasicConfigType.definitions.CPUAffinityConfiguration.properties.pcpu_id
},
pcpu_owned() {
- return vueUtils.getPathVal(this.rootFormData, 'own_pcpu')
+ return this.is_std_vm ? vueUtils.getPathVal(this.rootFormData, 'own_pcpu') : 'y'
},
uiOptions() {
return formUtils.getUiOptions({
@@ -178,8 +178,7 @@ export default {
this.defaultVal.pcpu.splice(index + 1, 0, {pcpu_id: null, real_time_vcpu: "n"})
},
click_own_pcpu() {
- let newValue = this.pcpu_owned === 'y' ? 'n' : 'y';
- vueUtils.setPathVal(this.rootFormData, 'own_pcpu', newValue)
+ return this.is_std_vm ? (this.pcpu_owned === 'y' ? 'n' : 'y') : 'y'
},
removePCPU(index) {
if (this.defaultVal.pcpu.length === 1) {
--
2.25.1
Junjie Mao
toggle quoted message
Show quoted text
Or is there any other reason that we need the other two line of changes?
---
Best Regards
Junjie Mao
-----Original Message-----I think this line alone is sufficient to make the generated scenario XML read reasonable, which is the only concern as of now.
From: root <yuanyuan.zhao@...>
Sent: Friday, November 18, 2022 11:21 AM
To: Mao, Junjie <junjie.mao@...>; acrn-dev@...
Cc: yuanyuan.zhao@...
Subject: [PATCH] config_tools: expose own_pcpu to RTVM
From: Yuanyuan Zhao <yuanyuan.zhao@...>
Expose own_pcpu widget to RTVM. Fix the value to true for RTVM
always own pcpus.
Signed-off-by: Yuanyuan Zhao <yuanyuan.zhao@...>
---
.../pages/Config/ConfigForm/CustomWidget/cpu_affinity.vue | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git
a/misc/config_tools/configurator/packages/configurator/src/pages/Config/ConfigForm/CustomW
idget/cpu_affinity.vue
b/misc/config_tools/configurator/packages/configurator/src/pages/Config/ConfigForm/CustomW
idget/cpu_affinity.vue
index 75939d193..4933ff3e6 100644
---
a/misc/config_tools/configurator/packages/configurator/src/pages/Config/ConfigForm/CustomW
idget/cpu_affinity.vue
+++
b/misc/config_tools/configurator/packages/configurator/src/pages/Config/ConfigForm/CustomW
idget/cpu_affinity.vue
@@ -3,7 +3,7 @@
<b>{{ uiOptions.title }}</b>
<div class="p-4">
<div v-if="defaultVal.pcpu && defaultVal.pcpu.length>0">
- <b-row v-if="is_std_vm">
+ <b-row>
<label>
<n-popover trigger="hover" placement="top-start" style="width: 500px">
<template #trigger>
@@ -146,7 +146,7 @@ export default {
return
window.getCurrentFormSchemaData().BasicConfigType.definitions.CPUAffinityConfiguration.pro
perties.pcpu_id
},
pcpu_owned() {
- return vueUtils.getPathVal(this.rootFormData, 'own_pcpu')
+ return this.is_std_vm ? vueUtils.getPathVal(this.rootFormData, 'own_pcpu') : 'y'
Or is there any other reason that we need the other two line of changes?
---
Best Regards
Junjie Mao
},
uiOptions() {
return formUtils.getUiOptions({
@@ -178,8 +178,7 @@ export default {
this.defaultVal.pcpu.splice(index + 1, 0, {pcpu_id: null, real_time_vcpu: "n"})
},
click_own_pcpu() {
- let newValue = this.pcpu_owned === 'y' ? 'n' : 'y';
- vueUtils.setPathVal(this.rootFormData, 'own_pcpu', newValue)
+ return this.is_std_vm ? (this.pcpu_owned === 'y' ? 'n' : 'y') : 'y'
},
removePCPU(index) {
if (this.defaultVal.pcpu.length === 1) {
--
2.25.1
Zhao, Yuanyuan
On 2022/11/18 13:20, Junjie Mao wrote:
Next line make sure that the velue of own_pcpu don't change when user click the widget.-----Original Message-----I think this line alone is sufficient to make the generated scenario XML read reasonable, which is the only concern as of now.
From: root <yuanyuan.zhao@...>
Sent: Friday, November 18, 2022 11:21 AM
To: Mao, Junjie <junjie.mao@...>; acrn-dev@...
Cc: yuanyuan.zhao@...
Subject: [PATCH] config_tools: expose own_pcpu to RTVM
From: Yuanyuan Zhao <yuanyuan.zhao@...>
Expose own_pcpu widget to RTVM. Fix the value to true for RTVM
always own pcpus.
Signed-off-by: Yuanyuan Zhao <yuanyuan.zhao@...>
---
.../pages/Config/ConfigForm/CustomWidget/cpu_affinity.vue | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git
a/misc/config_tools/configurator/packages/configurator/src/pages/Config/ConfigForm/CustomW
idget/cpu_affinity.vue
b/misc/config_tools/configurator/packages/configurator/src/pages/Config/ConfigForm/CustomW
idget/cpu_affinity.vue
index 75939d193..4933ff3e6 100644
---
a/misc/config_tools/configurator/packages/configurator/src/pages/Config/ConfigForm/CustomW
idget/cpu_affinity.vue
+++
b/misc/config_tools/configurator/packages/configurator/src/pages/Config/ConfigForm/CustomW
idget/cpu_affinity.vue
@@ -3,7 +3,7 @@
<b>{{ uiOptions.title }}</b>
<div class="p-4">
<div v-if="defaultVal.pcpu && defaultVal.pcpu.length>0">
- <b-row v-if="is_std_vm">
+ <b-row>
<label>
<n-popover trigger="hover" placement="top-start" style="width: 500px">
<template #trigger>
@@ -146,7 +146,7 @@ export default {
return
window.getCurrentFormSchemaData().BasicConfigType.definitions.CPUAffinityConfiguration.pro
perties.pcpu_id
},
pcpu_owned() {
- return vueUtils.getPathVal(this.rootFormData, 'own_pcpu')
+ return this.is_std_vm ? vueUtils.getPathVal(this.rootFormData, 'own_pcpu') : 'y'
Or is there any other reason that we need the other two line of changes?
---
Best Regards
Junjie Mao},
uiOptions() {
return formUtils.getUiOptions({
@@ -178,8 +178,7 @@ export default {
this.defaultVal.pcpu.splice(index + 1, 0, {pcpu_id: null, real_time_vcpu: "n"})
},
click_own_pcpu() {
- let newValue = this.pcpu_owned === 'y' ? 'n' : 'y';
- vueUtils.setPathVal(this.rootFormData, 'own_pcpu', newValue)
+ return this.is_std_vm ? (this.pcpu_owned === 'y' ? 'n' : 'y') : 'y'
},
removePCPU(index) {
if (this.defaultVal.pcpu.length === 1) {
--
2.25.1