Date
1 - 5 of 5
[PATCH] Instruction missing for L2-only users
|
Chuang Ke
In the cache widget, the instructions appears if the board has L3 only, L2 only, or both.
and delete "L3 Cache Allocation Technology" heading. there are instructions: "Drag the ends of the boxes to cover the cache chunks you want to allocate to specific VMs. If you have a real-time VM,ensure its cache chunks do not overlap with any other VM's cache chunks." Signed-off-by: Chuang-Ke <chuangx.ke@...> Tracked-On: #7921 --- .../src/pages/Config/ConfigForm/CustomWidget/CAT.vue | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/misc/config_tools/configurator/packages/configurator/src/pages/Config/ConfigForm/CustomWidget/CAT.vue b/misc/config_tools/configurator/packages/configurator/src/pages/Config/ConfigForm/CustomWidget/CAT.vue index 6dc554298..5a64a3c2f 100644 --- a/misc/config_tools/configurator/packages/configurator/src/pages/Config/ConfigForm/CustomWidget/CAT.vue +++ b/misc/config_tools/configurator/packages/configurator/src/pages/Config/ConfigForm/CustomWidget/CAT.vue @@ -61,9 +61,7 @@ {{ CAT_INFO.errorMsg }} </div> <div class="py-4" v-for="CACHE_ALLOCATION in CAT_INFO.regions" v-if="RDT_ENABLED==='y'"> - <p v-if="CACHE_ALLOCATION.level===3"> - L3 Cache Allocation Technology - <br/> + <p v-if="CACHE_ALLOCATION.level===3||CACHE_ALLOCATION.level===2"> Drag the ends of the boxes to cover the cache chunks you want to allocate to specific VMs. If you have a real-time VM,ensure its cache chunks do not overlap with any other VM's cache chunks. -- 2.25.1 |
|
|
|
Junjie Mao
Chuang Ke <chuangx.ke@...> writes:
In the cache widget, the instructions appears if the board has L3 only, L2 only, or both.If we remove the title here, how do users tell which widget is for L3/L2? -- Best Regards Junjie Mao + <p v-if="CACHE_ALLOCATION.level===3||CACHE_ALLOCATION.level===2"> |
|
|
|
Chuang Ke
@Mao, Junjie It's already repeat in title L3/L2 Cache Allocation Technology
- L3 Cache Allocation TechnologyThis just a repeated text not a title, as the comments asked to remove, after remove, the title still in the view no change. Best Regards, Chuang Ke -----Original Message----- From: Mao, Junjie <junjie.mao@...> Sent: 2022年7月27日 23:41 To: Ke, ChuangX <chuangx.ke@...> Cc: acrn-dev@...; Xie, Nanlin <nanlin.xie@...> Subject: Re: [PATCH] Instruction missing for L2-only users Chuang Ke <chuangx.ke@...> writes: In the cache widget, the instructions appears if the board has L3 only, L2 only, or both.If we remove the title here, how do users tell which widget is for L3/L2? -- Best Regards Junjie Mao + <p v-if="CACHE_ALLOCATION.level===3||CACHE_ALLOCATION.level===2"> |
|
|
|
Junjie Mao
"Ke, ChuangX" <chuangx.ke@...> writes:
@Mao, Junjie It's already repeat in title L3/L2 Cache Allocation TechnologyOK then.- L3 Cache Allocation TechnologyThis just a repeated text not a title, as the comments asked to remove, after remove, the title still in the view no change. -- Best Regards Junjie Mao
|
|
|
|
Chuang Ke
When I try to fix the bug from bug report description, I find two issue cause the problem:
toggle quoted message
Show quoted text
1. part of code in the translate function not match xml file(user offered) anymore, I have to rewrite the function to trans xml data so that xml data could import in correctly 2. when I fix issue 1, the import still not working, All non-rt VMs have set way mask to 0x0ff, because some mask function can't get data. Then I find out after translate xml file, regionData structure have issue, regionData.level and regionData.id are in the reverse order. In fact, it means config tools can't read any xml regionData, that's why it set All non-rt VMs mask to default value 0x0ff when it can't get data. Because level and id is in reverse order, I also believe it export error data. Right now , I think I fixed the two problem. maybe someone need to check and test on it. Best Regards, -----Original Message-----
From: Ke, ChuangX Sent: 2022年7月27日 15:43 To: Mao, Junjie <Junjie.Mao@...> Cc: acrn-dev@...; Xie, Nanlin <Nanlin.Xie@...> Subject: RE: [PATCH] Instruction missing for L2-only users @Mao, Junjie It's already repeat in title L3/L2 Cache Allocation Technology - L3 Cache Allocation TechnologyThis just a repeated text not a title, as the comments asked to remove, after remove, the title still in the view no change. Best Regards, Chuang Ke -----Original Message----- From: Mao, Junjie <junjie.mao@...> Sent: 2022年7月27日 23:41 To: Ke, ChuangX <chuangx.ke@...> Cc: acrn-dev@...; Xie, Nanlin <nanlin.xie@...> Subject: Re: [PATCH] Instruction missing for L2-only users Chuang Ke <chuangx.ke@...> writes: In the cache widget, the instructions appears if the board has L3 only, L2 only, or both.If we remove the title here, how do users tell which widget is for L3/L2? -- Best Regards Junjie Mao + <p v-if="CACHE_ALLOCATION.level===3||CACHE_ALLOCATION.level===2"> |
|
|