acrn-dev@lists.projectacrn.org | [PATCH 4/6] DM USB: xHCI: refine port assignment logic

Home Messages Hashtags Subgroups

Date Date 1 - 3 of 3

[PATCH 4/6] DM USB: xHCI: refine port assignment logic

Wu, Xiaoguang #10452 On 18-08-13 21:40:58, Yu Wang wrote: On 18-08-13 16:48:33, Wu, Xiaoguang wrote: The variable native_assign_ports in struct pci_xhci_vdev is used to record wether certain root hub port in SOS is assgned to UOS. The logic is zero reserve and nonzero assignement. In this patch, the meaning of native_assign_ports is expand to the following logic: native_assign_ports[x][y] = 0: native port x-y is not assigned. native_assign_ports[x][y] < 0: native port x-y is assigned but currently no virtual device attached. native_assign_ports[x][y] > 0: native paort x-y is assigned and virtual device attached to virtual port whose number is stored in native_assign_ports[x][y]. Signed-off-by: Xiaoguang Wu <xiaoguang.wu@...> Reviewed-by: Liang Yang <liang3.yang@...> --- devicemodel/hw/pci/xhci.c \| 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/devicemodel/hw/pci/xhci.c b/devicemodel/hw/pci/xhci.c index f12126b..2df7ce3 100644 --- a/devicemodel/hw/pci/xhci.c +++ b/devicemodel/hw/pci/xhci.c @@ -373,7 +373,16 @@ struct pci_xhci_vdev { int (excap_write)(struct pci_xhci_vdev , uint64_t, uint64_t); int usb2_port_start; int usb3_port_start; - uint8_t native_assign_ports[USB_NATIVE_NUM_BUS]; + + / native_assign_ports is used to record the assigment information: + * native_assign_ports[x][y] = 0: native port x-y is not assigned. + * native_assign_ports[x][y] < 0: native port x-y is assigned but + * currently no virtual device attached. + * native_assign_ports[x][y] > 0: native paort x-y is assigned and For "= 0" and "< 0", please define some macros... xgwu: will use macro to express, like the following: #define NATIVE_PORT_ASSIGNED(bus, port) (native_assign_ports[(bus)][(port)] != 0) ok, will change. thanks + * virtual device attached to virtual port whose number + * is stored in native_assign_ports[x][y]. + / + int8_t native_assign_ports[USB_NATIVE_NUM_BUS]; struct timespec mf_prev_time; /* previous time of accessing MFINDEX / }; @@ -3365,14 +3374,14 @@ pci_xhci_parse_bus_port(struct pci_xhci_vdev xdev, char *opts) if (!xdev->native_assign_ports[bus]) { xdev->native_assign_ports[bus] = calloc(USB_NATIVE_NUM_PORT, - sizeof(uint8_t)); + sizeof(int8_t)); if (!xdev->native_assign_ports[bus]) { rc = -3; goto errout; } } + xdev->native_assign_ports[bus][port] = -1; - xdev->native_assign_ports[bus][port] = 1; errout: if (rc) UPRINTF(LWRN, "%s fails, rc=%d\r\n", __func__, rc); -- 2.7.4
More All Messages By This Member
Yu Wang #10426 On 18-08-13 16:48:33, Wu, Xiaoguang wrote: The variable native_assign_ports in struct pci_xhci_vdev is used to record wether certain root hub port in SOS is assgned to UOS. The logic is zero reserve and nonzero assignement. In this patch, the meaning of native_assign_ports is expand to the following logic: native_assign_ports[x][y] = 0: native port x-y is not assigned. native_assign_ports[x][y] < 0: native port x-y is assigned but currently no virtual device attached. native_assign_ports[x][y] > 0: native paort x-y is assigned and virtual device attached to virtual port whose number is stored in native_assign_ports[x][y]. Signed-off-by: Xiaoguang Wu <xiaoguang.wu@...> Reviewed-by: Liang Yang <liang3.yang@...> --- devicemodel/hw/pci/xhci.c \| 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/devicemodel/hw/pci/xhci.c b/devicemodel/hw/pci/xhci.c index f12126b..2df7ce3 100644 --- a/devicemodel/hw/pci/xhci.c +++ b/devicemodel/hw/pci/xhci.c @@ -373,7 +373,16 @@ struct pci_xhci_vdev { int (excap_write)(struct pci_xhci_vdev , uint64_t, uint64_t); int usb2_port_start; int usb3_port_start; - uint8_t native_assign_ports[USB_NATIVE_NUM_BUS]; + + / native_assign_ports is used to record the assigment information: + * native_assign_ports[x][y] = 0: native port x-y is not assigned. + * native_assign_ports[x][y] < 0: native port x-y is assigned but + * currently no virtual device attached. + * native_assign_ports[x][y] > 0: native paort x-y is assigned and For "= 0" and "< 0", please define some macros... + * virtual device attached to virtual port whose number + * is stored in native_assign_ports[x][y]. + / + int8_t native_assign_ports[USB_NATIVE_NUM_BUS]; struct timespec mf_prev_time; /* previous time of accessing MFINDEX / }; @@ -3365,14 +3374,14 @@ pci_xhci_parse_bus_port(struct pci_xhci_vdev xdev, char *opts) if (!xdev->native_assign_ports[bus]) { xdev->native_assign_ports[bus] = calloc(USB_NATIVE_NUM_PORT, - sizeof(uint8_t)); + sizeof(int8_t)); if (!xdev->native_assign_ports[bus]) { rc = -3; goto errout; } } + xdev->native_assign_ports[bus][port] = -1; - xdev->native_assign_ports[bus][port] = 1; errout: if (rc) UPRINTF(LWRN, "%s fails, rc=%d\r\n", __func__, rc); -- 2.7.4
More All Messages By This Member
Wu, Xiaoguang #10408 The variable native_assign_ports in struct pci_xhci_vdev is used to record wether certain root hub port in SOS is assgned to UOS. The logic is zero reserve and nonzero assignement. In this patch, the meaning of native_assign_ports is expand to the following logic: native_assign_ports[x][y] = 0: native port x-y is not assigned. native_assign_ports[x][y] < 0: native port x-y is assigned but currently no virtual device attached. native_assign_ports[x][y] > 0: native paort x-y is assigned and virtual device attached to virtual port whose number is stored in native_assign_ports[x][y]. Signed-off-by: Xiaoguang Wu <xiaoguang.wu@...> Reviewed-by: Liang Yang <liang3.yang@...> --- devicemodel/hw/pci/xhci.c \| 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/devicemodel/hw/pci/xhci.c b/devicemodel/hw/pci/xhci.c index f12126b..2df7ce3 100644 --- a/devicemodel/hw/pci/xhci.c +++ b/devicemodel/hw/pci/xhci.c @@ -373,7 +373,16 @@ struct pci_xhci_vdev { int (excap_write)(struct pci_xhci_vdev , uint64_t, uint64_t); int usb2_port_start; int usb3_port_start; - uint8_t native_assign_ports[USB_NATIVE_NUM_BUS]; + + / native_assign_ports is used to record the assigment information: + * native_assign_ports[x][y] = 0: native port x-y is not assigned. + * native_assign_ports[x][y] < 0: native port x-y is assigned but + * currently no virtual device attached. + * native_assign_ports[x][y] > 0: native paort x-y is assigned and + * virtual device attached to virtual port whose number + * is stored in native_assign_ports[x][y]. + / + int8_t native_assign_ports[USB_NATIVE_NUM_BUS]; struct timespec mf_prev_time; /* previous time of accessing MFINDEX / }; @@ -3365,14 +3374,14 @@ pci_xhci_parse_bus_port(struct pci_xhci_vdev xdev, char *opts) if (!xdev->native_assign_ports[bus]) { xdev->native_assign_ports[bus] = calloc(USB_NATIVE_NUM_PORT, - sizeof(uint8_t)); + sizeof(int8_t)); if (!xdev->native_assign_ports[bus]) { rc = -3; goto errout; } } + xdev->native_assign_ports[bus][port] = -1; - xdev->native_assign_ports[bus][port] = 1; errout: if (rc) UPRINTF(LWRN, "%s fails, rc=%d\r\n", __func__, rc); -- 2.7.4
More All Messages By This Member

1 - 3 of 3

1

Previous Topic Next Topic

Home Hashtags Subgroups Terms