Question about code wrapped by #if 0 #if


Kaige Fu
 

Hi all,

There are three code segments wrapped by #if 0. Can we just remove them?

devicemodel/hw/pci/virtio/virtio_rpmb.c:394:#if 0
hypervisor/arch/x86/vmexit.c:385:#if 0
hypervisor/arch/x86/vmexit.c:413:#if 0

--
Thanks
Kaige, Fu


Tian, Kevin
 

yes, all dead code should be killed.

-----Original Message-----
From: acrn-dev@lists.projectacrn.org [mailto:acrn-
dev@lists.projectacrn.org] On Behalf Of Kaige Fu
Sent: Tuesday, May 29, 2018 3:52 PM
To: acrn-dev@lists.projectacrn.org
Subject: [acrn-dev] Question about code wrapped by #if 0

Hi all,

There are three code segments wrapped by #if 0. Can we just remove them?

devicemodel/hw/pci/virtio/virtio_rpmb.c:394:#if 0
hypervisor/arch/x86/vmexit.c:385:#if 0
hypervisor/arch/x86/vmexit.c:413:#if 0

--
Thanks
Kaige, Fu


Kaige Fu
 

Hi kevin,

On 2018/5/29 15:52, Tian, Kevin wrote:
yes, all dead code should be killed.
I'll cook a patch.

--
Thanks
Kaige, Fu
-----Original Message-----
From: acrn-dev@lists.projectacrn.org [mailto:acrn-
dev@lists.projectacrn.org] On Behalf Of Kaige Fu
Sent: Tuesday, May 29, 2018 3:52 PM
To: acrn-dev@lists.projectacrn.org
Subject: [acrn-dev] Question about code wrapped by #if 0

Hi all,

There are three code segments wrapped by #if 0. Can we just remove them?

devicemodel/hw/pci/virtio/virtio_rpmb.c:394:#if 0
hypervisor/arch/x86/vmexit.c:385:#if 0
hypervisor/arch/x86/vmexit.c:413:#if 0

--
Thanks
Kaige, Fu