OK. I have drop this patch and send others to PR.

I am fine with this. Once you get +1 for the misc patches, please PR.

Aaa, If this is the case, we have to drop this patch.

It seems we should confirm this patch again. I will pause this patch and send others of this series to PR. >

OK, I will change it. >

Chenli Wei <chenli.wei@...> writes: A reminder: using enumeration constants as integers is prohibited by ACRN coding guideline. In this case the enumeration above is not exhaustive (due to the v

Chenli Wei <chenli.wei@...> writes: Reviewed-by: Junjie Mao <junjie.mao@...> One minor comment below. Why do you need `concat` here? A single ',' should do the trick.

Chenli Wei <chenli.wei@...> writes: As a general guideline, please append "Reviewed-by" or "Acked-by" after "Signed-off-by".

The current code define *PIO_IDX by macro, it's not a good style and the UART PIO was in the middle of these macro which should move to the end to conveniently modify. This patch change these macro to

Current code limit the MAX vUART number to 8 which is not enough for Service VM which should config S5 UART for each user VM. We could count how many vUARTs we need by offline tool, so remove the defi

The current code define MAX_VUART_NUM_PER_VM for all VM and it's a hard code which can't match our vUART logic which need dynamic setting. This patch move the define of MAX_VUART_NUM_PER_VM to offline

"S5" is one of the ACPI sleep states which means the function to shut down the VMs. On ACRN, the User VM must be shut down before powering off the Service VM, so we need a vUART channel to communicate

"S5" is one of the ACPI sleep states which means the function to shut down the VMs. On ACRN, the User VM must be shut down before powering off the Service VM, so we need a vUART channel to communicate

OK, I will change the logic of get MAX number. >

Chenli Wei <chenli.wei@...> writes: There is no guarantee that the service VM has the most vUART controllers. Also there can be cases where the service VM is absent. Thus, you need to collect th

Chenli Wei <chenli.wei@...> writes: Reviewed-by: Junjie Mao <junjie.mao@...>

The current code define *PIO_IDX by macro, it's not a good style and the UART PIO was in the middle of these macro which should move to the end to conveniently modify. This patch change these macro to

Current code limit the MAX vUART number to 8 which is not enough for Service VM which should config S5 UART for each user VM. We could count how many vUARTs we need by offline tool, so remove the defi

The current code define MAX_VUART_NUM_PER_VM for all VM and it's a hard code which can't match our vUART logic which need dynamic setting. This patch move the define of MAX_VUART_NUM_PER_VM to offline