Previously ASL_COMPILER macro that indicates iasl location was passed from host build machine environment, this makes no sense on target machine. If user has a specific iasl path on host, then

Acked-by: Wang, Yu1 <yu1.wang@...>

The patch fix many bugs about the pci msi capabilities. 1. Fix the clear msi mask bit issues. 2. Initialize the offset of pci capabilities this variable will used as the output of

The patch fix many bugs about the pci msi capabilities. 1. Fix the clear msi mask bit issues. 2. Initialize the offset of pci capabilities this variable will used as the output of

Please explain the detailed fixes. This patch has several fix, please list them one by one. I see.

offset + PCIR_MSI_CTRL If you add such fields into the msicap, then we should use them to check mask and pending? Otherwise, what're their meaning?

The patch fix the msi clear pending bit issue, add new struct element in the msicap struct, we will use this element by address pointer. Signed-off-by: Liu Long <long.liu@...> ---

Please add comments to explain the detailed fields of each MSR like like IA32_HWP_CAP(771H), MSR_PLATFORM_INFO, IA32_MPERF, etc. Please define macros for 0x6, and (0x1U << 7) It is hard to understand

This is used to check whether the HWP is supported. Can we use the function name of is_hwp_supported?

Better to have a comment, that the patch has a pre-condition: host CPUID.06H:EAX.[7] can't be hidden by vCPUID of Service VM.

When running WaaG, we need to enable HWP to boost performance in some scenarios. But when HWP is enabled in BIOS, windows does not turn on HWP driver automatically just like Linux does. It

Acked-by: Eddie Dong <eddie.dong@...>

Yes,  we could remove the default="0x00400000" and we need the minOccurs="0". There was a schema error if we remove both the "default" and "minOccurs" parameters. >

Chenli Wei <chenli.wei@...> writes: The default value seems to be useless here as you have logic in the static allocator to determine one if it is not given. -- Best Regards Junjie

From: Chenli Wei <chenli.wei@...> The current code assume that there must be an HV_RAM_START element in the scenario and we will generate it if user have not set, the default value of

Acked-by: Wang, Yu1 <yu1.wang@...>

From: Sun Peng <peng.p.sun@...> Virtual display is component which based on native window system. This feature depended phisical monitor connected and graphic driver in SOS running

Please return -1 and do exit(1) in main() with an error log.

From: Sun Peng <peng.p.sun@...> Virtual display is component which based on native window system. This feature depended phisical monitor connected and graphic driver in SOS running