OK, this is my fault. I am not aware the code here has been changed to prepare_vm() recently. I will fix it in my next version. The purpose here is want to return a failure. Is it better to return a

In general we should do in different patch for bug fix. But this one is simple for those compile option --- this looks like MISRAC patches, we can do together to save

Absolutely, we should do it. This should be done in another patch, right? > > >

Acked-by: Yu Wang <yu1.wang@...>

Haven't fix the v2 comment... Please add one log followed v2 suggestion

Can you please also modify the documentation (README.rst [1]) to reflect these changes? [1] https://github.com/projectacrn/acrn-hypervisor/blob/master/tools/acrntrace/README.rst Thanks, Geoffroy

Is it better to be "(p->wildcard || p->data == data)" ?

The variable native_assign_ports in struct pci_xhci_vdev is used to record wether certain root hub port in SOS is assgned to UOS. The logic is zero reserve and nonzero assignement. In this patch, the

This patch enable the support for SOS S3 from the perspective of USB xHCI. Signed-off-by: Xiaoguang Wu <xiaoguang.wu@...> Reviewed-by: Liang Yang <liang3.yang@...> ---

The xHCI emulation greatly depends on the user space library libusb which is based on the usbfs module in Linux kernel. The libusb will bind usbfs to physical USB device which makes hardware control

Current design cannot get physical USB device information without the creation of pci_xhci_dev_emu. This brings some dificulties in certain situations, hence struct usb_native_devinfo is introduced to

Current DM design use two variables to do the indexing of xHCI Event Ring: er_enq_idx and er_events_cnt. They are members of the struct pci_xhci_rtsregs. In UOS, during the process of xHCI resuming,

PORTSC (Port Status and Control Register) register play a very important role in USB sub-system. This patch is used to refine related manipulation functions. Signed-off-by: Xiaoguang Wu

This patchset enable the USB xHCI S3 feature. Xiaoguang Wu (6): DM USB: xHCI: fix an xHCI issue to enable UOS s3 feature DM USB: xHCI: refine xHCI PORTSC Register related functions DM USB:

Hi Eddie/Anthony, Do you have any comments on this one?

HI Eddie, do you mean misra violation that mingqiang addressed? If so, please give me a ACK in my V2 patch. BR, Victor

Acked-by: Eddie Dong <eddie.dong@...>