Re: [PATCH] [config_tool] Order of plus and minus icons is inconsistent


Junjie Mao
 

Chuang Ke <chuangx.ke@...> writes:

let minus icons in front of plus icons in those view below:
Virtio input device, Virtio network device, Virtio console device , CPU affinity

Signed-off-by: Chuang-Ke <chuangx.ke@...>
Fine with me as long as this is motivated by DX comments.

--
Best Regards
Junjie Mao

Tracked-on: #7917
---
.../Config/ConfigForm/CustomWidget/Virtio/Console.vue | 1 +
.../pages/Config/ConfigForm/CustomWidget/cpu_affinity.vue | 8 ++++----
2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/misc/config_tools/configurator/packages/configurator/src/pages/Config/ConfigForm/CustomWidget/Virtio/Console.vue b/misc/config_tools/configurator/packages/configurator/src/pages/Config/ConfigForm/CustomWidget/Virtio/Console.vue
index 173dd7168..01596ab9c 100644
--- a/misc/config_tools/configurator/packages/configurator/src/pages/Config/ConfigForm/CustomWidget/Virtio/Console.vue
+++ b/misc/config_tools/configurator/packages/configurator/src/pages/Config/ConfigForm/CustomWidget/Virtio/Console.vue
@@ -188,6 +188,7 @@ export default {
<style scoped>
.ToolSet {
display: flex;
+ flex-direction: row;
justify-content: space-around;
margin: 1rem;
gap: 0.5rem;
diff --git a/misc/config_tools/configurator/packages/configurator/src/pages/Config/ConfigForm/CustomWidget/cpu_affinity.vue b/misc/config_tools/configurator/packages/configurator/src/pages/Config/ConfigForm/CustomWidget/cpu_affinity.vue
index c796a2d56..c4bd9aeed 100644
--- a/misc/config_tools/configurator/packages/configurator/src/pages/Config/ConfigForm/CustomWidget/cpu_affinity.vue
+++ b/misc/config_tools/configurator/packages/configurator/src/pages/Config/ConfigForm/CustomWidget/cpu_affinity.vue
@@ -33,14 +33,14 @@
</b-col>
<b-col>
<div class="ToolSet">
- <div @click="addPCPU(index)" :class="{'d-none': (this.defaultVal.pcpu.length-1)!==index}">
+ <div @click="removePCPU(index)">
<Icon size="18px">
- <Plus/>
+ <Minus/>
</Icon>
</div>
- <div @click="removePCPU(index)">
+ <div @click="addPCPU(index)" :class="{'d-none': (this.defaultVal.pcpu.length-1)!==index}">
<Icon size="18px">
- <Minus/>
+ <Plus/>
</Icon>
</div>
</div>

Join acrn-dev@lists.projectacrn.org to automatically receive all group messages.