On Tue, Jun 14, 2022 at 01:28:33AM +0000, Long Liu wrote:
-----Original Message----- From: acrn-dev@... <acrn-dev@...> On Behalf Of Yu Wang Sent: Tuesday, June 14, 2022 9:04 AM To: Liu Long <long.liu@...> Cc: Huang, Yonghua <yonghua.huang@...>; acrn-dev@... Subject: Re: [acrn-dev] [PATCH 1/2] ACRN: DM: Release vsock struct in case memory leak
On Tue, Jun 14, 2022 at 09:23:55AM +0800, Liu Long wrote:
When deinit the vhost vsock release the vhost vsock struct to prevent memory leak.
Signed-off-by: Liu Long <long.liu@...> --- devicemodel/hw/pci/virtio/vhost_vsock.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/devicemodel/hw/pci/virtio/vhost_vsock.c b/devicemodel/hw/pci/virtio/vhost_vsock.c index e2aa06acd..544c392df 100644 --- a/devicemodel/hw/pci/virtio/vhost_vsock.c +++ b/devicemodel/hw/pci/virtio/vhost_vsock.c @@ -211,22 +211,21 @@ fail: static int vhost_vsock_deinit(struct vhost_vsock *vhost_vsock) { - int rc; + int rc = 0;
rc = vhost_vsock_stop(vhost_vsock); if (rc < 0) { pr_err("vhost_dev_stop is failed.\n"); - return -1; }