Re: [PATCH] misc: Limit IVSHMEM region name to 27 characters


Liu, Yifan1
 

Sure. Will do.

-----Original Message-----
From: Mao, Junjie <junjie.mao@...>
Sent: Wednesday, June 1, 2022 5:00 PM
To: Liu, Yifan1 <yifan1.liu@...>
Cc: acrn-dev@...
Subject: Re: [acrn-dev] [PATCH] misc: Limit IVSHMEM region name to 27 characters

"Liu, Yifan1" <yifan1.liu@...> writes:

From: Yifan Liu <yifan1.liu@...>

Current IVSHMEM region name does not have size limit. This patch limits
it to 27 characters so that land specifier ("hv:/" or "dm:/") plus region
name can fit into an array of 32 characters.

Signed-off-by: Yifan Liu <yifan1.liu@...>
---
misc/config_tools/schema/types.xsd | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/misc/config_tools/schema/types.xsd b/misc/config_tools/schema/types.xsd
index e4e7eefc0..9bfc62536 100644
--- a/misc/config_tools/schema/types.xsd
+++ b/misc/config_tools/schema/types.xsd
@@ -249,10 +249,10 @@ Read more about the available scheduling options in :ref:`cpu_sharing`.</xs:docu
</xs:annotation>
<xs:simpleType>
<xs:annotation>
- <xs:documentation>A string with no spaces.</xs:documentation>
+ <xs:documentation>A string with up to 27 characters of digits, letters and ``_``.</xs:documentation>
You may also want to update the placeholder of the corresponding
widget. IVSHMEM regions are configured using customized widgets. Thus,
the placeholder, i.e. the string in grey in the widget when users leave
it empty, is hardcoded in the vue file.

--
Best Regards
Junjie Mao

</xs:annotation>
<xs:restriction base="xs:string">
- <xs:pattern value="\w+" />
+ <xs:pattern value="\w{1,27}" />
</xs:restriction>
</xs:simpleType>
</xs:element>

Join acrn-dev@lists.projectacrn.org to automatically receive all group messages.