Re: [PATCH v2] drm/i915/gvt: disable the PIPE_FAULT_ERROR for gvt-d


Wu, Xiaoguang
 

-----Original Message-----
From: Wang, Yu1 <yu1.wang@...>
Sent: Wednesday, March 18, 2020 9:42 PM
To: Wu, Xiaoguang <xiaoguang.wu@...>
Cc: acrn-dev@...; Zhao, Yakui <yakui.zhao@...>; Liu,
Xinyun <xinyun.liu@...>
Subject: Re: [PATCH v2] drm/i915/gvt: disable the PIPE_FAULT_ERROR for
gvt-d

On 20-03-18 20:59:05, Xiaoguang Wu wrote:
From: Zhao Yakui <yakui.zhao@...>

This is a WA for too many error logs after GPU iommu is enabled.

Signed-off-by: Zhao Yakui <yakui.zhao@...>
Reviewed-by: Liu Xinyun <xinyun.liu@...>
---
drivers/gpu/drm/i915/i915_irq.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_irq.c
b/drivers/gpu/drm/i915/i915_irq.c index 5e0e9f1..f416ec2 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -4217,7 +4217,8 @@ static void gen8_de_irq_postinstall(struct
drm_i915_private *dev_priv)
de_misc_masked |= GEN8_DE_MISC_GSE;

if (INTEL_GEN(dev_priv) >= 9) {
- de_pipe_masked |= GEN9_DE_PIPE_IRQ_FAULT_ERRORS;
+ /* FIXME: this is a WA to avoid too many kernel log */
This comment is still not clear. Please provide similiar comments like below
example:

/* FIXME: disable PIPE FAULT IRQs due to XXX warnings are continuous
* print during WaaG GOP stage but stop after enter Windows desktop.
* These warnings have no functionality impact, so disable the logs
* as WA first and revert until root caused.
*/
Xgwu: ok, will change, thx.

BTW, do we really need to disable the warning logs? If it is harmlessly, why
we have to disable it?
Xgwu: without this change, the booting time of guest will be very long.


+ /* de_pipe_masked |= GEN9_DE_PIPE_IRQ_FAULT_ERRORS;
*/
de_port_masked |= GEN9_AUX_CHANNEL_B |
GEN9_AUX_CHANNEL_C |
GEN9_AUX_CHANNEL_D;
if (IS_GEN9_LP(dev_priv))
--
2.7.4

Join acrn-dev@lists.projectacrn.org to automatically receive all group messages.