Re: [PATCH] HV: hv_main: Add #ifdef HV_DEBUG before debug specific code

Home Messages Hashtags Subgroups

Eddie Dong #10415 In general we should do in different patch for bug fix. But this one is simple for those compile option --- this looks like MISRAC patches, we can do together to save toggle quoted messageShow quoted text -----Original Message----- From: acrn-dev@... [mailto:acrn-dev@...] On Behalf Of Kaige Fu Sent: Monday, August 13, 2018 5:18 PM To: acrn-dev@... Subject: Re: [acrn-dev] [PATCH] HV: hv_main: Add #ifdef HV_DEBUG before debug specific code On 08-13 Mon 08:27, Eddie Dong wrote: On 08-13 Mon 07:59, Eddie Dong wrote: This is part of SBUF component, what kind of compile option do we use? Let us use same one. shell command "vmexit" is the only one user of vmexit_time/cnt and we use the get_vmexit_profile, enclosed by HV_DEBUG, to access these variables. Ok then. BTW, hcall side also needs this kind of compile option. I can't follow here. Can you make it more clear. The sbuf has a hypercall, we need compile option to cover all sbuf code... Absolutely, we should do it. This should be done in another patch, right?
More All Messages By This Member

Join acrn-dev@lists.projectacrn.org to automatically receive all group messages.